Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

nsoffer at redhat.com nsoffer at redhat.com
Sun Dec 13 20:43:25 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
......................................................................


Patch Set 17:

(1 comment)

https://gerrit.ovirt.org/#/c/48672/17/vdsm/v2v.py
File vdsm/v2v.py:

Line 646:             raise
Line 647:         seen = set()
Line 648:         # Support for old libvirt clients
Line 649:         for name in conn.listDefinedDomains():
Line 650:             seen.add(name)
Should be after we got the vm object using lookupByName(). Otherwise may may miss a vm that was returned from listDevicedDomains(), but change state before lookupByName().

Even if this is not possible with current libvirt code, this is the correct thing to do - you remember the vm you returned.
Line 651:             vm = conn.lookupByName(name)
Line 652:             yield vm
Line 653:         for vmid in conn.listDomainsID():
Line 654:             vm = conn.lookupByID(vmid)


-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list