Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

nsoffer at redhat.com nsoffer at redhat.com
Sun Dec 13 15:32:39 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: gluster: Warn about missing glusterfs-cli package
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/50363/4/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 359:     def _get_gluster_volinfo(self):
Line 360:         if not gluster_cli.gluster_exists():
Line 361:             self.log.warning("Required glusterfs-cli package is missing "
Line 362:                              "on this host. Please install the package "
Line 363:                              "in order to use gluster storage")
This check must be done earlier. If gluster is not installed, there is no point in getting volume info, we know that it will fail.

We must not fail the mount in this case.
Line 364: 
Line 365:         volinfo = supervdsm.getProxy().glusterVolumeInfo(self._volname,
Line 366:                                                          self._volfileserver)
Line 367:         return volinfo[self._volname]


-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list