Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

ykaplan at redhat.com ykaplan at redhat.com
Sun Dec 13 14:32:10 UTC 2015


Yeela Kaplan has posted comments on this change.

Change subject: Makefile: use tox to run make pep8 and pyflakes
......................................................................


Patch Set 3:

(6 comments)

https://gerrit.ovirt.org/#/c/49952/3/tox.ini
File tox.ini:

Line 3: skipsdist = true
Line 4: [testenv:py27]
Line 5: deps =
Line 6: 	pyflakes==0.9.2
Line 7: 	pep8==1.5.6
> We don't need tabs, this is not a makefile.
Done
Line 8: commands=


https://gerrit.ovirt.org/#/c/49952/3/tox.sh
File tox.sh:

Line 19: PEP8_BLACKLIST=(config.py \
Line 20: 	        constants.py \
Line 21: 	        crossImportsTests.py \
Line 22: 	        vdsm.py \
Line 23: 	       )
> Tabs
Done
Line 24: 
Line 25: if [ 'pyflakes' == $1 ]; then
Line 26: 	(find . -path './.tox' -prune -type f -o \
Line 27: 	    -path './.git' -prune -type f -o \


Line 21: 	        crossImportsTests.py \
Line 22: 	        vdsm.py \
Line 23: 	       )
Line 24: 
Line 25: if [ 'pyflakes' == $1 ]; then
> Should use single "=", see man test.
Done
Line 26: 	(find . -path './.tox' -prune -type f -o \
Line 27: 	    -path './.git' -prune -type f -o \
Line 28: 	    -name '*.py' -o -name '*.py.in' && echo "${WHITELIST[@]}") | \
Line 29: 	    xargs pyflakes | grep -w -v "${SKIP_PYFLAKES_ERR}" | \


Line 26: 	(find . -path './.tox' -prune -type f -o \
Line 27: 	    -path './.git' -prune -type f -o \
Line 28: 	    -name '*.py' -o -name '*.py.in' && echo "${WHITELIST[@]}") | \
Line 29: 	    xargs pyflakes | grep -w -v "${SKIP_PYFLAKES_ERR}" | \
Line 30: 	    while read LINE; do echo "$LINE"; false; done
> Please covert the tabs to spaces, they were needed only in the makefile.
Done
Line 31: fi
Line 32: 
Line 33: if [ 'pep8' == $1 ]; then
Line 34: 	for x in ${PEP8_BLACKLIST[@]}; do \


Line 29: 	    xargs pyflakes | grep -w -v "${SKIP_PYFLAKES_ERR}" | \
Line 30: 	    while read LINE; do echo "$LINE"; false; done
Line 31: fi
Line 32: 
Line 33: if [ 'pep8' == $1 ]; then
> Same
Done
Line 34: 	for x in ${PEP8_BLACKLIST[@]}; do \
Line 35: 	exclude="$${exclude},$${x}" ; \
Line 36: 		done ; \
Line 37: 		pep8 --exclude="$${exclude}" --exclude='.tox/*' \


Line 35: 	exclude="$${exclude},$${x}" ; \
Line 36: 		done ; \
Line 37: 		pep8 --exclude="$${exclude}" --exclude='.tox/*' \
Line 38: 		--filename '*.py,*.py.in' . \
Line 39: 		"${WHITELIST[@]}"
> Tabs
Done


-- 
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list