Change in vdsm[master]: v2v: test get_ova_info with via directory input

nsoffer at redhat.com nsoffer at redhat.com
Sun Dec 13 12:43:20 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: v2v: test get_ova_info with via directory input
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/50158/4/tests/v2vTests.py
File tests/v2vTests.py:

Line 351: 
Line 352:         with open('fake-virt-v2v.out', 'r') as f:
Line 353:             self.assertEqual(output, f.read())
Line 354: 
Line 355:     def _checkOvaInfoOutput(self, vm):
> well now that we test get_ova_info we do parse the ova so we need a valid o
Agree.
Line 356:         self.assertEquals(vm['vmName'], 'First')
Line 357:         self.assertEquals(vm['memSize'], 2048)
Line 358:         self.assertEquals(vm['smp'], 1)
Line 359: 


-- 
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list