Change in vdsm[master]: hsm: organize imports.

nsoffer at redhat.com nsoffer at redhat.com
Sun Dec 13 12:00:56 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: hsm: organize imports.
......................................................................


Patch Set 1:

(7 comments)

https://gerrit.ovirt.org/#/c/50373/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 20
Line 21
Line 22
Line 23
Line 24
Check http://www.ovirt.org/Vdsm_Coding_Guidelines


Line 33
Line 34
Line 35
Line 36
Line 37
Should be sorted, may be a good idea to separate the "from x import y" imports.


Line 34
Line 35
Line 36
Line 37
Line 38
Keep this needed line.


Line 70
Line 71
Line 72
Line 73
Line 74
This group - from "import sp" to this line, the storage imports, should be sorted.

Looks like we need another group for "from x import y" after the storage imports.


Line 39: from vdsm.config import config
Line 40: from vdsm import constants
Line 41: from vdsm import supervdsm
Line 42: from vdsm import utils
Line 43: from vdsm import qemuimg
This group should be sorted.
Line 44: 
Line 45: import sp
Line 46: from spbackends import MAX_POOL_DESCRIPTION_SIZE, MAX_DOMAINS
Line 47: from spbackends import StoragePoolDiskBackend


Line 45: import sp
Line 46: from spbackends import MAX_POOL_DESCRIPTION_SIZE, MAX_DOMAINS
Line 47: from spbackends import StoragePoolDiskBackend
Line 48: from spbackends import StoragePoolMemoryBackend
Line 49: 
Remove unneeded line.
Line 50: import monitor
Line 51: import sd
Line 52: import blockSD
Line 53: import nfsSD


Line 75: import logUtils
Line 76: import mount
Line 77: import dispatcher
Line 78: import storageServer
Line 79: 
Remove this unneeded line.
Line 80: 
Line 81: GUID = "guid"
Line 82: NAME = "name"
Line 83: UUID = "uuid"


-- 
To view, visit https://gerrit.ovirt.org/50373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba1888c23b8fdea510547c5b26977ec71fd0d1e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list