Change in vdsm[master]: net: remove business logic out of CachingNetInfo

edwardh at redhat.com edwardh at redhat.com
Sun Dec 13 09:25:00 UTC 2015


Edward Haas has posted comments on this change.

Change subject: net: remove business logic out of CachingNetInfo
......................................................................


Patch Set 4:

(4 comments)

https://gerrit.ovirt.org/#/c/50000/4/lib/vdsm/netinfo/__init__.py
File lib/vdsm/netinfo/__init__.py:

Line 193: iteritems
Python3 compatibility issue
(It repeats here several times..)


https://gerrit.ovirt.org/#/c/50000/4/lib/vdsm/netinfo/bonding.py
File lib/vdsm/netinfo/bonding.py:

Line 190: bondings
Reusing the name of the argument, can we use a different name for clarity?


Line 190: iteritems
Python3 compatibility issue.


https://gerrit.ovirt.org/#/c/50000/4/lib/vdsm/netinfo/misc.py
File lib/vdsm/netinfo/misc.py:

Line 61: iteritems
Python3 compatibility


-- 
To view, visit https://gerrit.ovirt.org/50000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bae19df6721c7559e8eeac1db590026b401f76b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list