Change in vdsm[master]: storage: Introduction to transfer.py

aaviram at redhat.com aaviram at redhat.com
Sun Dec 13 09:06:39 UTC 2015


Amit Aviram has posted comments on this change.

Change subject: storage: Introduction to transfer.py
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/50014/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 524: {'command': {'class': 'Host', 'name': 'setHaMaintenanceMode'},
Line 525:  'data': {'mode': 'HaMaintenanceMode', 'enabled': 'bool'}}
Line 526: 
Line 527: ##
Line 528: # @Host.startImageTransferSession:
> It is not about tranfering an image, but about exposing an image using imag
(stop|start)ImagedSession sounds good, Done
Line 529: #
Line 530: # Start an image upload data transfer session.
Line 531: #
Line 532: # @ticketUUID:  Ticket UUID


Line 530: # Start an image upload data transfer session.
Line 531: #
Line 532: # @ticketUUID:  Ticket UUID
Line 533: #
Line 534: # @ops:         Comma-delimited operation list (e.g. "get, put")
> OK, so lets pass it as is to imaged.
Done
Line 535: #
Line 536: # @expiration:  Expiration epoch
Line 537: #
Line 538: # @spUUID:      Storage Pool UUID


Line 540: # @sdUUID:      Storage Domain UUID
Line 541: #
Line 542: # @imgUUID:     Image UUID
Line 543: #
Line 544: # @volUUID:     Volume UUID
> Transfering iso image to vdsm image? You must create a disk and prepare it 
Not to vdsm-image, but to an ISO domain: the flow is that a user will use webadmin to upload ISO files to ISO domains so he could connect it as CD-ROM to his VMs. so in that case no preparing should be done right? (as ISO domain files are not prepared by VDSM)
This will be another usage of this API, along uploading images to vdsm-images.
Line 545: #
Line 546: # Since: 4.17.4
Line 547: ##
Line 548: {'command': {'class': 'Host', 'name': 'startImageTransferSession'},


-- 
To view, visit https://gerrit.ovirt.org/50014
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b9ded4bde73b1ab504cae50d2cea726d4f77e51
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list