Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

nsoffer at redhat.com nsoffer at redhat.com
Sat Dec 12 23:33:52 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: Move getInfo and getVolumeParams
......................................................................


Patch Set 23: Code-Review-1

(2 comments)

- Missing indirection tests
- Missing redirections

https://gerrit.ovirt.org/#/c/41999/23/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 1111
Line 1112
Line 1113
Line 1114
Line 1115
Redirect to self._md?


Line 1200
Line 1201
Line 1202
Line 1203
Line 1204
Redirect to self._md - called when preparing a image for a vm


-- 
To view, visit https://gerrit.ovirt.org/41999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80c1fa58d64efbb3cbc7eea84189fc8375b6fa3d
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list