Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package
nsoffer at redhat.com
nsoffer at redhat.com
Sat Dec 12 18:42:28 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: gluster: Warn about missing glusterfs-cli package
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/50363/2/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 361: sVdsmProxy = supervdsm.getProxy()
Line 362: volinfo = sVdsmProxy.glusterVolumeInfo(self._volname,
Line 363: self._volfileserver)
Line 364: return volinfo[self._volname]
Line 365: except ge.GlusterCmdExecFailedException:
This is not correct, this error can be a failure of the gluster command line tool.
The correct check is to check if gluster command line tool exists, or the glusterfs-cli package exists (check need to be cross platform).
But these warning starts to be too much. The real fix is to require the package when it is available (X68_64).
Line 366: self.log.warning("Required glusterfs-cli package is missing on "
Line 367: "this host. Please install the package to work "
Line 368: "with gluster storage")
Line 369: raise
--
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list