Change in vdsm[master]: sdm: add create_volume_container API stub

nsoffer at redhat.com nsoffer at redhat.com
Sat Dec 12 10:14:55 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: sdm: add create_volume_container API stub
......................................................................


Patch Set 3:

(1 comment)

Partial review

https://gerrit.ovirt.org/#/c/50220/3/client/vdsClient.py
File client/vdsClient.py:

Line 2508:             '    - disk_type:     The type of disk (SYSTEM, DATA, SHARED, ..)',
Line 2509:             '    - description:   The volume description',
Line 2510:             '    - parent_img_id: Optional image UUID of the parent volume',
Line 2511:             '    - parent_vol_id: Optional volume UUID of the parent volume',
Line 2512:             '    - initial_size:  Optional requested initial allocated size '
requested -> desired, the semantics are similar, better name.

Lets also use this term in the schema.

Would it be nice if this help would be generated by the schema on the fly? (do not try this now).
Line 2513:             '(in bytes)'
Line 2514:         )),
Line 2515:         'extendVolumeSize': (serv.extendVolumeSize, (
Line 2516:             '<spUUID> <sdUUID> <imgUUID> <volUUID> <newSize>',


-- 
To view, visit https://gerrit.ovirt.org/50220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff2656f2dd427812e557e6587429759a9c0a845
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list