Change in vdsm[master]: clean refrences inorder to save memory.

nsoffer at redhat.com nsoffer at redhat.com
Fri Dec 11 18:29:31 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: clean refrences inorder to save memory.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/49346/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:

Line 220:         log.error("Unable to parse dd output: '%s'", err[-1])
Line 221:         raise se.MiscFileReadException(path)
Line 222: 
Line 223:     # clean those before return
Line 224:     del rc, _, err
rc is an integer, _ is empty string, and err is about 60 characters string.

We call this once every 10 seconds, there is no chance that this is related to high memory usage.
Line 225: 
Line 226:     return {
Line 227:         'bytes': int(m.group('bytes')),
Line 228:         'seconds': float(m.group('seconds')),


-- 
To view, visit https://gerrit.ovirt.org/49346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I566f9b6146b7f8cd69a3c3c2d1e90337011c6b6b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eldad Marciano <emarcian at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list