Change in vdsm[master]: storage: add a context manager for the domainLock

alitke at redhat.com alitke at redhat.com
Fri Dec 11 16:32:33 UTC 2015


Adam Litke has posted comments on this change.

Change subject: storage: add a context manager for the domainLock
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/50272/2/tests/manifest_tests.py
File tests/manifest_tests.py:

Line 191:     def dummy(self):
Line 192:         pass
Line 193: 
Line 194:     def fail(self):
Line 195:         raise InjectedFailure()
> Thinking again, we don't need this - we can simply raise in the context man
Done
Line 196: 
Line 197: 
Line 198: class DomainLockTests(VdsmTestCase):
Line 199: 


Line 213:         try:
Line 214:             with manifest.domain_lock(1):
Line 215:                 manifest.fail()
Line 216:         except InjectedFailure:
Line 217:             pass
> Better use self.assertRaises for this:
Done


-- 
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list