Change in vdsm[master]: virt: add run_async helper

fromani at redhat.com fromani at redhat.com
Fri Dec 11 10:54:11 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: add run_async helper
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/49570/3/vdsm/virt/utils.py
File vdsm/virt/utils.py:

Line 137:     If `logger` is set, unhandled exceptions which occurs
Line 138:     after the execution is succesfully started will be logged
Line 139:     on this logger; Otherwise the root logger will be used.
Line 140:     If `resource' is not None, run_async will acquire it
Line 141:     before to start the `func' callable, and will
> Omitted this one actually?
just missed a ':w' :(
Line 142:     release it once `func' exits.
Line 143:     `resource' must support the threading.Semaphore protocol.
Line 144:     If `error' is not None, it will be used as argument of
Line 145:     AsyncStartError.


-- 
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list