Change in vdsm[master]: virt: Add support for vgamem attribute

mzamazal at redhat.com mzamazal at redhat.com
Fri Dec 11 08:57:37 UTC 2015


Milan Zamazal has posted comments on this change.

Change subject: virt: Add support for vgamem attribute
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/50091/3/tests/deviceTests.py
File tests/deviceTests.py:

Line 292:                 <model heads="2" type="vga" vgamem="8192" vram="32768"/>
Line 293:             </video>"""
Line 294: 
Line 295:         dev = {'device': 'vga',
Line 296:                'specParams': {'vram': '32768', 'heads': '2', 'vgamem': '8192'}}
> This is ok, however it'd be nice with a follow up patch with more tests aro
Good idea, I'll add more tests (vgamem present or not present etc.) in a followup patch.
Line 297:         video = vmdevices.core.Video(self.conf, self.log, **dev)
Line 298:         self.assertXMLEqual(video.getXML().toxml(), videoXML)
Line 299: 
Line 300:     def testInterfaceXML(self):


-- 
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic595761ef7195ec12830dd7f057471512b5c6355
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list