Change in vdsm[master]: vdsm: introduce cpuinfo module

fromani at redhat.com fromani at redhat.com
Thu Dec 10 11:24:24 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vdsm: introduce cpuinfo module
......................................................................


Patch Set 16: Code-Review+1

(2 comments)

https://gerrit.ovirt.org/#/c/46912/16//COMMIT_MSG
Commit Message:

Line 12: more importantly, moves the code to vdsm library - allowing hooks to
Line 13: work with cpu info and architecture. This allows us to move fake_kvm
Line 14: to a hook.
Line 15: 
Line 16: The new modules are called cpuinfo and cpuarch.
you split cpuarch (thanks!) so this commit message needs to be updated, it doesn't?
Line 17: * Cpuinfo is the module that handles CPU properties such as frequency,
Line 18:  flags and it's model,
Line 19: * cpuarch handles everything related to CPU architecture from host's
Line 20:  and guest's viewpoint.


https://gerrit.ovirt.org/#/c/46912/16/vdsm/caps.py
File vdsm/caps.py:

Line 341:     return (_get_emulated_machines_from_domain(arch, caps) or
Line 342:             _get_emulated_machines_from_arch(arch, caps))
Line 343: 
Line 344: 
Line 345: def _getAllCpuModels(capfile=CPU_MAP_FILE, arch=None):
for a (far) future patch: maybe move into cpuarch, so arch_to_cpu_map could be made private?

For even more far future, we should sto parsing the libvirt cpu_map entirely.
Line 346: 
Line 347:     with open(capfile) as xml:
Line 348:         cpu_map = ET.fromstring(xml.read())
Line 349: 


-- 
To view, visit https://gerrit.ovirt.org/46912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa702b05f3825ebdcfed16d86d39a8c38fcf224c
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list