Change in vdsm[master]: virt: sampling: reduce host averaging window

danken at redhat.com danken at redhat.com
Thu Dec 10 07:59:33 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: sampling: reduce host averaging window
......................................................................


virt: sampling: reduce host averaging window

Host samples are stored into a SampleWindow of
size 5 for mostly historical reasons, with
no clear rationale.

However, a clear adverse effect of this setting
is new network devices are reported with a larger
delay, especially since commit 6547ea8b90fa191257
which enlarged the sample interval to 15s from
the previous, too frequent, interval of 2s.

To be reported, a network device must be present in
the first and the last sample.
For one hotplugged device, the delay can be high as
sample_interval * window_size.

To counter this delay, we reduce the sample window
size to two items, which is the minimum meaningful
value.

Change-Id: Ib5f416615058458321a03d7e149b1db243c34002
Bug-Url: https://bugzilla.redhat.com/1261457
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/50148
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/virt/sampling.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/50148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5f416615058458321a03d7e149b1db243c34002
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list