Change in vdsm[master]: Introduce VolumeArtifacts

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 9 23:10:53 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Introduce VolumeArtifacts
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/48097/4/vdsm/storage/sdm/volumeartifacts.py
File vdsm/storage/sdm/volumeartifacts.py:

Line 86:                                 self._meta_file_commit_path())
Line 87:         except OSError as e:
Line 88:             if e.errno == errno.ENOENT:
Line 89:                 raise VolumeArtifactsNotFound()
Line 90:             raise
> UUID_GLOB_PATTERN = '*-*-*-*-*'
Can we fix it to find only valid images?
Line 91: 
Line 92:         # If we created a new image directory, rename it to the correct name
Line 93:         if self._get_artifacts_path() == self._new_image_path():
Line 94:             self._oop.os.rename(self._get_artifacts_path(),


-- 
To view, visit https://gerrit.ovirt.org/48097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I352423e39a899b9b83ccf3b8f6c17ec433e9c353
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list