Change in vdsm[master]: storage: Introduction to transfer.py

alitke at redhat.com alitke at redhat.com
Wed Dec 9 21:03:21 UTC 2015


Adam Litke has posted comments on this change.

Change subject: storage: Introduction to transfer.py
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/50014/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 532: # @ticketUUID:  Ticket UUID
Line 533: #
Line 534: # @ops:         Comma-delimited operation list (e.g. "get, put")
Line 535: #
Line 536: # @expiration:  Expiration epoch
> I think "expires" is nicer.
This also depends on engine and vdsm being in time sync.  Do we want this parameter to be the number of seconds to keep the session open (from the time the API is called)?
Line 537: #
Line 538: # @spUUID:      Storage Pool UUID
Line 539: #
Line 540: # @sdUUID:      Storage Domain UUID


Line 540: # @sdUUID:      Storage Domain UUID
Line 541: #
Line 542: # @imgUUID:     Image UUID
Line 543: #
Line 544: # @volUUID:     Volume UUID
> This duplicates prepareImage. Maybe we should use prepareImage and teardown
I actually like the prepareImage bundled in the verb.  When would you ever want to start a session without having the image prepared?  We have to plumb the new verb through all of the layers regardless of whether or not the low level implementation calls prepareImage or not.
Line 545: #
Line 546: # Since: 4.17.4
Line 547: ##
Line 548: {'command': {'class': 'Host', 'name': 'startImageTransferSession'},


Line 576: # Extend an image upload data transfer session.
Line 577: #
Line 578: # @ticketUUID:  Ticket UUID
Line 579: #
Line 580: # @expiration:  Expiration epoch
> See comment in start...
Reset session to @expiration seconds from now?
Line 581: #
Line 582: # Since: 4.17.4
Line 583: ##
Line 584: {'command': {'class': 'Host', 'name': 'extendImageTransferSession'},


-- 
To view, visit https://gerrit.ovirt.org/50014
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b9ded4bde73b1ab504cae50d2cea726d4f77e51
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list