Change in vdsm[master]: virt: vm: Update time on VM after resume

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 9 19:05:35 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/48860/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1204:         t = time.time()
Line 1205:         seconds = int(t)
Line 1206:         nseconds = int((t - seconds) * 10**9)
Line 1207:         try:
Line 1208:             self._dom.setTime(time={'seconds': seconds, 'nseconds': nseconds})
> are we sure this never blocks or delays?
We will block here for 5 seconds when qemu-guest-agent is not installed, we see this today in freeze() and thaw().

Here an example:

    jsonrpc.Executor/0::INFO::2015-12-09 21:01:39,112::vm::2968::virt.vm::(freeze) vmId=`a8eab488-2019-4e1c-aefe-dccd8c519ff4`::Freezing guest filesystems
    jsonrpc.Executor/0::WARNING::2015-12-09 21:01:44,115::vm::2973::virt.vm::(freeze) vmId=`a8eab488-2019-4e1c-aefe-dccd8c519ff4`::Unable to freeze guest filesystems: Guest agent is not responding: Guest agent not available for now
    ...
    jsonrpc.Executor/0::INFO::2015-12-09 21:01:44,389::vm::2991::virt.vm::(thaw) vmId=`a8eab488-2019-4e1c-aefe-dccd8c519ff4`::Thawing guest filesystems
    jsonrpc.Executor/0::WARNING::2015-12-09 21:01:49,390::vm::2996::virt.vm::(thaw) vmId=`a8eab488-2019-4e1c-aefe-dccd8c519ff4`::Unable to thaw guest filesystems: Guest agent is not responding: Guest agent not available for now
Line 1209:         except libvirt.libvirtError as e:
Line 1210:             log_method = self.log.debug
Line 1211:             code = e.get_error_code()
Line 1212:             if code == libvirt.VIR_ERR_AGENT_UNRESPONSIVE:


-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list