Change in vdsm[master]: netinfo: assess DHCP on devices from cmdlines of dhclients

ibarkan at redhat.com ibarkan at redhat.com
Wed Dec 9 14:18:59 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients
......................................................................


Patch Set 11:

(1 comment)

except insisting on a test, looks good.

https://gerrit.ovirt.org/#/c/49097/11/tests/netinfoTests.py
File tests/netinfoTests.py:

Line 238: 
> I cannot see what I could actually do now.
why not monkey patch pgrep?


-- 
To view, visit https://gerrit.ovirt.org/49097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I160a0e2d4c734de94b0995e7433216baa88972ab
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list