Change in vdsm[master]: net: tests: test network's iface

phoracek at redhat.com phoracek at redhat.com
Wed Dec 9 13:53:20 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: net: tests: test network's iface
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/48366/6/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 225: 
Line 226:     def assertNetworkExists(self, networkName, bridged=None, bridgeOpts=None,
Line 227:                             hostQos=None, assert_in_running_conf=True):
Line 228:         netinfo = self.vdsm_net.netinfo
Line 229:         config = self.vdsm_net.config
> better do that in a follow-up patch
done here https://gerrit.ovirt.org/#/c/50004/
Line 230:         network_config = config.networks[networkName]
Line 231:         physical_iface = (network_config.get('bonding') or
Line 232:                           network_config.get('nic'))
Line 233:         self.assertIn(networkName, netinfo.networks)


-- 
To view, visit https://gerrit.ovirt.org/48366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If45fb63247b5e5b21721a23d8781a4ed80e58932
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list