Change in vdsm[master]: virt: Add support for vgamem attribute

fromani at redhat.com fromani at redhat.com
Wed Dec 9 09:21:29 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: Add support for vgamem attribute
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50091/2/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 293: ('
> Isn't something like:
not much :)
Please note that 'attr' is not visible outside the list comprehension; furthermore, this will add one list as value, while we want scalar attributes.

In general, we should use list comprehension/generator expressions when we want create a sequence, maybe from another sequence. In other cases, a loop is just fine.


-- 
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic595761ef7195ec12830dd7f057471512b5c6355
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list