Change in vdsm[master]: virt: vm: Update time on VM after resume

fromani at redhat.com fromani at redhat.com
Wed Dec 9 08:17:03 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

questions/comments for the new fakes, -1 for visibility.

https://gerrit.ovirt.org/#/c/48860/6/tests/vmfakelib.py
File tests/vmfakelib.py:

Line 234: 
Line 235:     @recorded
Line 236:     def setTime(self, time={}):
Line 237:         self._failIfRequested()
Line 238:         assert 'seconds' in time, time
we don't usuall put asserts in fake/mock methods.
Line 239:         assert 'nseconds' in time, time
Line 240:         seconds = time['seconds']
Line 241:         nseconds = time['nseconds']
Line 242:         assert 0 <= nseconds and nseconds < 10 ** 9, nseconds


Line 240:         seconds = time['seconds']
Line 241:         nseconds = time['nseconds']
Line 242:         assert 0 <= nseconds and nseconds < 10 ** 9, nseconds
Line 243:         passed_time = seconds + nseconds * 1.0 / 10 ** 9
Line 244:         import time as time_
and local, not module level imports are usually avoided.
Line 245:         assert abs(passed_time - time_.time()) < 1, time
Line 246: 
Line 247:     def setDiskErrors(self, diskErrors):
Line 248:         self._diskErrors = diskErrors


-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list