Change in vdsm[master]: stomp: Send all the pending messages in handle_write

danken at redhat.com danken at redhat.com
Tue Dec 8 15:48:51 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: stomp: Send all the pending messages in handle_write
......................................................................


stomp: Send all the pending messages in handle_write

We used to send one pending message in handle_write, and poll again,
which would wake up the reactor immediately since the socket is still
writable.

When socket is writable, we like to send all the pending data until
there is no data to send, or the socket buffers are full.

This change should send data quicker and consume less cpu time.

Change-Id: I35dad03942cb53f95c57cc6b48bd3ae93885a0d2
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48888
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
---
M lib/yajsonrpc/stomp.py
1 file changed, 16 insertions(+), 14 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/48888
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35dad03942cb53f95c57cc6b48bd3ae93885a0d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list