Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

ybronhei at redhat.com ybronhei at redhat.com
Tue Dec 8 13:25:20 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: improve functional network tests duration time
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/48356/2/tests/functional/utils.py
File tests/functional/utils.py:

Line 80:     def getInstance(cls):
Line 81:         with cls._instanceLock:
Line 82:             if cls._instance is None:
Line 83:                 cls._instance = VdsProxy()
Line 84:         return cls._instance
> Similar code is used in ClientIF and in java having singleton is not trivia
Nir means to override 'def __new__' afaik. Not so important Nir... this implementation is perfectly fine imo
Line 85: 
Line 86:     def start(self):
Line 87:         if _JSONRPC_ENABLED:
Line 88:             requestQueues = config.get('addresses', 'request_queues')


-- 
To view, visit https://gerrit.ovirt.org/48356
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list