Change in vdsm[master]: config: Resolve crash when IPv6 disabled in kernel

danken at redhat.com danken at redhat.com
Tue Dec 8 09:44:48 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: config: Resolve crash when IPv6 disabled in kernel
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

minor comment, please have this patch ready quickly.

https://gerrit.ovirt.org/#/c/47978/4/lib/vdsm/netinfo/__init__.py
File lib/vdsm/netinfo/__init__.py:

Line 91:         updates = propose_updates_to_reported_dhcp(network_info, networking)
Line 92:         update_reported_dhcp(updates, networking)
Line 93: 
Line 94:     report_network_qos(networking)
Line 95:     networking['supportsIPv6'] = ipv6_supported()
please add this in a separate patch, updating VdsmCapabilities in lib/api/vdsmapi-schema.json as well.
Line 96: 
Line 97:     return networking
Line 98: 
Line 99: 


-- 
To view, visit https://gerrit.ovirt.org/47978
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I774cac868ddee08ac072adf2104a811594779052
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ollie Armstrong <ollie at fubra.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ollie Armstrong <ollie at fubra.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list