Change in vdsm[master]: storage: perform image deletion in task

alitke at redhat.com alitke at redhat.com
Mon Dec 7 20:33:41 UTC 2015


Adam Litke has posted comments on this change.

Change subject: storage: perform image deletion in task
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/48477/4/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 200:         Return a type specific volume generator object
Line 201:         """
Line 202:         return fileVolume.FileVolume
Line 203: 
Line 204:     def _getDeletedImagePath(self, imgUUID):
Please make this a public method.  It is generally useful.  I have a patch for SDM that wants to use it.
Line 205:         currImgDir = self.getImagePath(imgUUID)
Line 206:         dirName, baseName = os.path.split(currImgDir)
Line 207:         toDelDir = os.path.join(dirName, sd.REMOVED_IMAGE_PREFIX + baseName)
Line 208:         return toDelDir


-- 
To view, visit https://gerrit.ovirt.org/48477
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e61d38439192d193f3f806e08661b61a65e7836
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list