Change in vdsm[master]: testlib: Allow recording class methods

alitke at redhat.com alitke at redhat.com
Mon Dec 7 15:44:43 UTC 2015


Adam Litke has submitted this change and it was merged.

Change subject: testlib: Allow recording class methods
......................................................................


testlib: Allow recording class methods

The @recorded decorator could not be applied to class methods, and we
are using lot of boilerplate code to record class methods.

This patch modify the decorator so it can be used to decorate both
instance and class methods.

Since class attributes are visible via the instance, we use
__recording__ for the instance, and __class_recording__ for the class.

Change-Id: Idf33cba4ab41dc4cc7cc09d4afa70d33b75cde9f
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/49960
Continuous-Integration: Jenkins CI
Reviewed-by: Freddy Rolland <frolland at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
---
M tests/testlib.py
M tests/testlibTests.py
2 files changed, 77 insertions(+), 4 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/49960
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf33cba4ab41dc4cc7cc09d4afa70d33b75cde9f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list