Change in vdsm[ovirt-3.6]: sp: Allow attaching of monitored domain

ybronhei at redhat.com ybronhei at redhat.com
Mon Dec 7 14:18:51 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: sp: Allow attaching of monitored domain
......................................................................


sp: Allow attaching of monitored domain

When attaching a storage domain to the pool, the storage domain may be
an external domain being monitored via startMonitoringDomain, such as the
hosted engine storage domain.

In this case, the monitor may have already acquired the host id, or will
acquire it during the attach operation. We cannot tell since monitors
are using asynchronous acquire.

We must not release the host id when the domain is attached, since this
will cause sanlock to kill any process holding a resource on this
storage domain, such as the qemu process running the hosted engine vm.

We had a magical, sneaky, and unclear code for attaching a monitored
domain when starting a monitor twice. This code is now simplified and
documented, and logging is improved. This will be replaced with explicit
attach later.

Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192
Bug-Url: https://bugzilla.redhat.com/1269768
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48217
Continuous-Integration: Jenkins CI
Reviewed-by: Freddy Rolland <frolland at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/49597
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Roy Golan <rgolan at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Continuous-Integration: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/storage/monitor.py
M vdsm/storage/sp.py
2 files changed, 35 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
  Roy Golan: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/49597
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list