Change in vdsm[master]: spec: Align RHEL and CentOS qemu* requiments

amureini at redhat.com amureini at redhat.com
Mon Dec 7 13:15:26 UTC 2015


Allon Mureinik has posted comments on this change.

Change subject: spec: Align RHEL and CentOS qemu* requiments
......................................................................


Patch Set 2:

Pyflakes error on F23 in the CI doesn't have anything to do with this patch:

11:40:24 Compiling './tests/hoststatsTests.py'...
11:40:24 Compiling './tests/stompAdapterTests.py'...
11:40:24 Compiling './tests/clientifTests.py'...
11:40:24 Compiling './tests/netconfpersistenceTests.py'...
11:40:24 python -c 'import pyflakes; print("pyflakes-%s" % pyflakes.__version__)'
11:40:24 pyflakes-1.0.0
11:40:24 ( find . -path './.git' -prune -type f -o \
11:40:24 	-name '*.py' -o -name '*.py.in' && \
11:40:24 	echo contrib/logdb contrib/profile-stats init/daemonAdapter vdsm/get-conf-item vdsm/set-conf-item vdsm/supervdsmServer vdsm/vdsm vdsm/vdsm-restore-net-config vdsm/storage/curl-img-wrap vdsm/storage/fc-scan vdsm-tool/vdsm-tool  ) | xargs /usr/bin/pyflakes | \
11:40:24 	grep -w -v "\./vdsm/storage/lvm\.py.*: list comprehension redefines 'lv' from line .*" | \
11:40:24 	while read LINE; do echo "$LINE"; false; done
11:40:24 ./lib/vdsm/constants.py.in:26:29: invalid syntax
11:40:24 GLUSTER_MGMT_ENABLED = bool(@GLUSTER_MGMT@)
11:40:24                             ^
11:40:24 ./lib/vdsm/netinfo/__init__.py:150: import 'info' from line 41 shadowed by loop variable
11:40:24 ./lib/vdsm/netinfo/vlans.py:63: local variable 'speed' (defined in enclosing scope on line 24) referenced before assignment
11:40:24 Makefile:986: recipe for target 'pyflakes' failed
11:40:24 make: *** [pyflakes] Error 1
11:40:24 Took 22 seconds

-- 
To view, visit https://gerrit.ovirt.org/49974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bfb1035641fd03ecd3c7b38f398a2b7679f4801
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list