Change in vdsm[master]: hooks: ovs: set OVS devices UP

danken at redhat.com danken at redhat.com
Mon Dec 7 12:49:29 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: set OVS devices UP
......................................................................


Patch Set 8: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/48388/8/tests/functional/networkTestsOVS.py
File tests/functional/networkTestsOVS.py:

Line 42: setupModule
networkTests should be monkey-patched here


Line 138: delattr(NetworkTest, t)
this is very evil - we should simply replace them with

  def skip():
    raise SkipTest('Does not use OVS')

etc.


-- 
To view, visit https://gerrit.ovirt.org/48388
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list