Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

fromani at redhat.com fromani at redhat.com
Mon Dec 7 12:06:49 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: caps/lib: move CPU architecture details to lib/cpuarch
......................................................................


Patch Set 1: Code-Review+1

Thanks Martin for the awesome work and the further improvements.
Looks good.

Jenkins failure unrelated:
00:05:45.904 ./lib/vdsm/netinfo/__init__.py:150: import 'info' from line 41 shadowed by loop variable
00:05:45.904 ./lib/vdsm/netinfo/vlans.py:63: local variable 'speed' (defined in enclosing scope on line 24) referenced before assignment

-- 
To view, visit https://gerrit.ovirt.org/49972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46bb51769562fbb9d816d190c2aebfd0660cc3b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list