Change in vdsm[master]: vm: Support for non-ascii vm name

mskrivan at redhat.com mskrivan at redhat.com
Mon Dec 7 09:49:30 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: vm: Support for non-ascii vm name
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/48570/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 384:         if isinstance(name, unicode):
Line 385:             # Libvirt does not support non-ascii vm name
Line 386:             # See https://bugzilla.redhat.com/1260131
Line 387:             try:
Line 388:                 name = name.encode('ascii')
don't we also need to make it unique?
Line 389:             except UnicodeEncodeError:
Line 390:                 self.log.debug("Non-ASCII vm name '%s'", name.encode('utf8'))
Line 391:                 name = None
Line 392:         if name is None:


-- 
To view, visit https://gerrit.ovirt.org/48570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2386c0f98aeb8161feaf19c2862be229f73eb0df
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list