Change in vdsm[master]: net: move qos reporting to netinfo

danken at redhat.com danken at redhat.com
Mon Dec 7 06:06:49 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: move qos reporting to netinfo
......................................................................


net: move qos reporting to netinfo

Up until now, qos reporting was part of caps.py, which lies in an
upper layer then netinfo, just because the tc code could not be used
from within netinfo. Now it is possible to bury this reporting code
inside netinfo new package, where it belongs.
Note, that this change creates a circular import because the
configurators/qos.py code is used from netinfo/qos.py but is trying to
import netinfo itself. This was solved by moving _root_qdisc to
netinfo/qos.py. This actually makes sense, because nobody should be
dependant on network/configurators for the sake of reporting stuff-
especially not the main reporting code (netinfo package). The only qos
reporting code is now left in vdsm/tc.

Change-Id: Ie3526c4ae609f29561904bddacc1e9f9194435e9
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/49620
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Continuous-Integration: Jenkins CI
---
M debian/vdsm-python.install
M lib/vdsm/netinfo/Makefile.am
M lib/vdsm/netinfo/__init__.py
A lib/vdsm/netinfo/qos.py
M lib/vdsm/network/configurators/qos.py
M lib/vdsm/tc/__init__.py
M tests/functional/networkTests.py
M tests/qosTests.py
M tests/tcTests.py
M vdsm.spec.in
M vdsm/caps.py
11 files changed, 95 insertions(+), 64 deletions(-)

Approvals:
  Ido Barkan: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49620
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3526c4ae609f29561904bddacc1e9f9194435e9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list