Change in vdsm[master]: tests: modprobe validation handle failure
ibarkan at redhat.com
ibarkan at redhat.com
Sun Dec 6 15:14:13 UTC 2015
Ido Barkan has posted comments on this change.
Change subject: tests: modprobe validation handle failure
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/49538/3/tests/modprobe.py
File tests/modprobe.py:
Line 72: def _fail_to_load_module(name, rc, out, err):
: raise SkipTest("This test requires %s module (failed to load module: "
: "rc=%s, out=%s, err=%s)" % (name, rc, out, err))
I would not extract a function for this. This code is self evident (reads for what is does) and is not reused anywhere else. Remember python is not 0 cost abstraction.
--
To view, visit https://gerrit.ovirt.org/49538
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I276cc2cf2205323648364c62b9db8f40e14cc983
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list