Change in vdsm[master]: net: Mapping bonding option value names to numerics

ibarkan at redhat.com ibarkan at redhat.com
Sun Dec 6 15:02:00 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/49390/12/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 233: 
Line 234:     return vals
Line 235: 
Line 236: 
Line 237: def _bond_opts_name2numeric_getval(opt_path, opt_wr_file, numeric_val):
> if it will not break the line in two, i would prefer s/opt_wr_file/opt_writ
+1
Line 238:     try:
Line 239:         opt_wr_file.write(str(numeric_val))
Line 240:         opt_wr_file.flush()
Line 241:     except IOError as e:


-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list