Change in vdsm[master]: virt: vm: Update time on VM after resume

nsoffer at redhat.com nsoffer at redhat.com
Sun Dec 6 14:32:46 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/48860/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2802:             hooks.after_vm_dehibernate(self._dom.XMLDesc(0), self.conf,
Line 2803:                                        {'FROM_SNAPSHOT': fromSnapshot})
Line 2804:             # TODO: _syncTime() should probably be called for both the
Line 2805:             # restore_state and migration_dest paths, but let's handle just the
Line 2806:             # safer case first.
This comment does not belong here. Either move it to the commit message, or add TODO in the other flows that needs this. Also "handle the safer case" should explain why this is safer than the other cases. Better explain in the unsafe cases why this is unsafe.
Line 2807:             self._syncTime()
Line 2808:         elif 'migrationDest' in self.conf:
Line 2809:             if self._needToWaitForMigrationToComplete():
Line 2810:                 usedTimeout = self._waitForUnderlyingMigration()


-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list