Change in vdsm[master]: Adding toolTests.py to python3 check modules

nsoffer at redhat.com nsoffer at redhat.com
Sun Dec 6 13:17:06 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Adding toolTests.py to python3 check modules
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/48052/8/lib/vdsm/tool/configfile.py
File lib/vdsm/tool/configfile.py:

Line 260
Line 261
Line 262
Line 263
Line 264
> using io.open(path, 'r', encoding='utf8') returns unicode on both python 2 
Do we want unicode? open(path, "rb") should return bytes in both 2 and 3.

When we write configuration file containing ascii only content, there is no need to work with unicode.


-- 
To view, visit https://gerrit.ovirt.org/48052
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52f11a1a10cae46773d05d0c09da80ad8eb3b772
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list