Change in vdsm[master]: net: consolidate nics.py naming

danken at redhat.com danken at redhat.com
Sun Dec 6 12:18:24 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net: consolidate nics.py naming
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/49624/5/lib/vdsm/netinfo/__init__.py
File lib/vdsm/netinfo/__init__.py:

Line 41: info
in this context, "info" is to general. Please import as nic_info.


-- 
To view, visit https://gerrit.ovirt.org/49624
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I807c9c4a78e0e9e02fb034987c8667d76f42fbad
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list