Change in vdsm[master]: coverage: Add vdsm-coverage sub package
sbonazzo at redhat.com
sbonazzo at redhat.com
Sun Dec 6 08:50:43 UTC 2015
Sandro Bonazzola has posted comments on this change.
Change subject: coverage: Add vdsm-coverage sub package
......................................................................
Patch Set 4:
(5 comments)
See inline comments
https://gerrit.ovirt.org/#/c/49807/4/coverage/README.md
File coverage/README.md:
Line 25: Run this to create html report in vdsm-coverage directory:
Line 26:
Line 27: coverage html --rcfile /etc/vdsm/coverage.conf
Line 28:
Line 29: To view the report, open a web server the vdsm-coverage directory:
"open a web server the vdsm-coverage directory" shold be something like
"make the vdsm-coverage directory available on a we server, for example:"
A couple of words about why you need a web server instead of browsing the directory with your preferred browser may be useful as well.
Line 30:
Line 31: cd vdsm-coverage
Line 32: python -m SimpleHTTPServer
Line 33:
Line 45: See https://wiki.jenkins-ci.org/display/JENKINS/Cobertura+Plugin
Line 46:
Line 47: ## Notes
Line 48:
Line 49: On EL7, coverage is too old. Use pip to install a recent version:
Can you detail which version is required? We can manage to provide it in some public repository.
Line 50:
Line 51: pip install -U coverage
Line 52:
Line 53: Note that coverage data files generated with coverage 3.6 cannot be processed
https://gerrit.ovirt.org/#/c/49807/4/coverage/coverage.conf.in
File coverage/coverage.conf.in:
Line 8: @VDSMDIR@
Line 9: vdsm
Line 10:
Line 11: [html]
Line 12: title = Vdsm coverage report
Still not sure about Vdsm vs VDSM.
Line 13: directory = vdsm-coverage
Line 14:
Line 15: [xml]
https://gerrit.ovirt.org/#/c/49807/4/coverage/vdsm.in
File coverage/vdsm.in:
Line 1: # Vdsm environment varibales
here as well
Line 2:
Line 3: # Enable coverage report using specified configuration
https://gerrit.ovirt.org/#/c/49807/4/vdsm.spec.in
File vdsm.spec.in:
Line 628: Gluster plugin enables VDSM to serve Gluster functionalities.
Line 629: %endif
Line 630:
Line 631: %package coverage
Line 632: Summary: Code coverage for VDSM
Here you're using VDSM instead of Vdsm, need to uniform somehow
Line 633: Requires: python-coverage
Line 634:
Line 635: %description coverage
Line 636: This package contains configuration files for generating code coverage
--
To view, visit https://gerrit.ovirt.org/49807
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95454731ca1c19e6f01417d2c26023e7c748365a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Balogh <pbalogh at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list