Change in vdsm[master]: coverage: Add vdsm-coverage sub package

pbalogh at redhat.com pbalogh at redhat.com
Sat Dec 5 20:00:14 UTC 2015


Petr Balogh has posted comments on this change.

Change subject: coverage: Add vdsm-coverage sub package
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/49807/3/coverage/README.md
File coverage/README.md:

Line 17: Retart
Restart


https://gerrit.ovirt.org/#/c/49807/3/coverage/coverage.conf.in
File coverage/coverage.conf.in:

Line 1: # Vdsm coverage configuration
Line 2: # See http://coverage.readthedocs.org/en/latest/config.html
Line 3: 
Line 4: [run]
Line 5: 
Are you going to run coverage on multiple hosts together? (Because we are going..) What about add also:
parallel = True

You can collect all coverage data to one of host and run coverage combine command before coverage html command and you can create report from multiple hosts. If you will run coverage only on one host it doesn't matter if there is only one coverage file from one host..

What do you think?
Line 6: data_file = @VDSMRUNDIR@/vdsm.coverage
Line 7: 
Line 8: branch = True
Line 9: 


Line 9: 
Line 10: source =
Line 11:     @VDSMDIR@
Line 12:     vdsm
Line 13
I'm thinking about add exact path where to write the HTML report files. Maybe better for automation, because you exactly know where you can find these files?
This is possible with add section [html]
http://coverage.readthedocs.org/en/latest/config.html#html
You can also add some title.

[html]
title = VDSM code coverage report
directory = @VDSMRUNDIR@/vdsm_html_coverage

And same for xml report
[xml]
output =  = @VDSMRUNDIR@/vdsm_coverage.xml

This could be useful if you would like use jenkins plugin cobertura for show report from this xml file in jenkins as we are going to.


-- 
To view, visit https://gerrit.ovirt.org/49807
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95454731ca1c19e6f01417d2c26023e7c748365a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Balogh <pbalogh at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list