Change in vdsm[master]: VolumeMetadata: move refreshVolume

alitke at redhat.com alitke at redhat.com
Fri Dec 4 21:16:22 UTC 2015


Adam Litke has posted comments on this change.

Change subject: VolumeMetadata: move refreshVolume
......................................................................


Patch Set 21:

(1 comment)

https://gerrit.ovirt.org/#/c/42003/21/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:

Line 325:     def metaoff(self):
Line 326:         return self._md.metaoff
Line 327: 
Line 328:     def refreshVolume(self):
Line 329:         lvm.refreshLVs(self.sdUUID, (self.volUUID,))
> Don't we need to remove it since it moved to md ?
Good catch.  This needs an indirection call.
Line 330: 
Line 331:     @classmethod
Line 332:     def halfbakedVolumeRollback(cls, taskObj, sdUUID, volUUID, volPath):
Line 333:         cls.log.info("sdUUID=%s volUUID=%s volPath=%s" %


-- 
To view, visit https://gerrit.ovirt.org/42003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5041428d8d2e73edc1aa1362fcea8801e5b9116
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list