Change in vdsm[master]: gluster: fix brick devices are created with incorrect data a...

rnachimu at redhat.com rnachimu at redhat.com
Fri Dec 4 10:52:47 UTC 2015


Ramesh N has posted comments on this change.

Change subject: gluster: fix brick devices are created with incorrect data alignment
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/47959/2/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 59: DEFAULT_METADATA_SIZE_KB = 16777216
Line 60: MIN_VG_SIZE = 1048576
Line 61: MIN_METADATA_PERCENT = 0.005
Line 62: DEFAULT_FS_TYPE = "xfs"
Line 63: DEFAULT_MOUNT_OPTIONS = "inode64,noatime"
> inode64 is pretty important. I think it is the default in RHEL-7, but not i
I verified the rhel7 and rhel6 docs. inode64 is default in RHEL-7 but not with RHEL-6. How about noatime. Is it really required in std use case?.
Line 64: 
Line 65: 
Line 66: def _getDeviceDict(device, createBrick=False):
Line 67:     info = {'name': device.name,


-- 
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai <mpillai at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list