Change in vdsm[master]: migration: make status field private
mzamazal at redhat.com
mzamazal at redhat.com
Fri Dec 4 10:32:58 UTC 2015
Milan Zamazal has posted comments on this change.
Change subject: migration: make status field private
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/49522/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 296: self._finishSuccessfully()
Line 297: except libvirt.libvirtError as e:
Line 298: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_ABORTED:
Line 299: self._last_status = response.error('migCancelErr',
Line 300: message='Migration canceled')
PEP8 indentation problem here after renaming.
Line 301: raise
Line 302: finally:
Line 303: if '_migrationParams' in self._vm.conf:
Line 304: del self._vm.conf['_migrationParams']
--
To view, visit https://gerrit.ovirt.org/49522
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic14e19f0576512dde081a2bb575915563843ee87
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list