Change in vdsm[master]: getAllImages: Use manifest attributes when constructing glob...

nsoffer at redhat.com nsoffer at redhat.com
Fri Dec 4 10:02:07 UTC 2015


Nir Soffer has submitted this change and it was merged.

Change subject: getAllImages: Use manifest attributes when constructing glob pattern
......................................................................


getAllImages: Use manifest attributes when constructing glob pattern

getAllImages searches a domain's images directory for directories that
look like a UUID.  To make this function testable with domains that are
not located at the usual storage repo location '/rhev/data-center', find
the images directory using the StorageDomainManifest's mountpoint
attribute.  Note that this is how getAllVolumes already works.

Change-Id: I8e69d3096a1b4c20dcee33e96c8a7bdd1b8dcaa9
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/49684
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Jenkins CI
---
M tests/manifest_tests.py
M vdsm/storage/fileSD.py
2 files changed, 10 insertions(+), 6 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e69d3096a1b4c20dcee33e96c8a7bdd1b8dcaa9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list