Change in vdsm[master]: hooks: ovs: skip non-vNic device's XML

danken at redhat.com danken at redhat.com
Fri Dec 4 08:07:13 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: hooks: ovs: skip non-vNic device's XML
......................................................................


hooks: ovs: skip non-vNic device's XML

If other than a vNic device is passed to OVS hook's
before_device_create, we end with an IndexError, because of XML
does not contain all required tags.

If such error occurs, return unchanged XML,

Change-Id: I457d43847f07cccbd56b562fbc7c111a0bb0e1a3
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/49183
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm_hooks/ovs/ovs_before_device_create.py
1 file changed, 14 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49183
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I457d43847f07cccbd56b562fbc7c111a0bb0e1a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list