Change in vdsm[master]: StorageDomainManifest: Manifest objects produce VolumeMetada...

alitke at redhat.com alitke at redhat.com
Thu Dec 3 21:30:48 UTC 2015


Adam Litke has posted comments on this change.

Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata objects
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/44040/7//COMMIT_MSG
Commit Message:

Line 9: When we are working directly with StorageDomainManifest objects we do
Line 10: not want to produce Volume objects.  Instead, we'll produce
Line 11: VolumeMetadata objects.  The interface between Volume and VolumeMetadata
Line 12: is consistent (except that VolumeMetadata lacks functions that can only
Line 13: be called when working with an SPM).
> What about old callers of getVolumeClass()?
They're working with StorageDomain objects and will get either BlockVolume or FileVolume as appropriate.
Line 14: 
Line 15: Change-Id: Iacb2723c8ce2108b3e5ac2f35be2f59f083095e0


-- 
To view, visit https://gerrit.ovirt.org/44040
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb2723c8ce2108b3e5ac2f35be2f59f083095e0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list