Change in vdsm[master]: hooks: ovs: use a class instead of NamedTuple for IPConfig

phoracek at redhat.com phoracek at redhat.com
Thu Dec 3 17:51:14 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: hooks: ovs: use a class instead of NamedTuple for IPConfig
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/49235/3/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
File vdsm_hooks/ovs/ovs_before_network_setup_ip.py:

Line 46:     def __init__(self, net, attrs):
Line 47:         self.top_dev = net if 'vlan' in attrs else BRIDGE_NAME
Line 48:         self.ipv4 = _get_ipv4_model(attrs)
Line 49:         self.ipv6 = _get_ipv6_model(attrs)
Line 50:         self.port = attrs.get('nic') or attrs.get('bonding')
> shouldn't this be the other way around?
i don't think it matters, but i changed it.
Line 51:         self.blocking_dhcp = 'blockingdhcp' in attrs
Line 52: 
Line 53: 
Line 54: def _get_ipv4_model(attrs):


-- 
To view, visit https://gerrit.ovirt.org/49235
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic26e637d14e9542a65438f5e2b509abc20055ce2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list