Change in vdsm[ovirt-3.5]: vm: add support for "Crashed" event

fromani at redhat.com fromani at redhat.com
Thu Dec 3 16:11:57 UTC 2015


Hello Dan Kenigsberg, Milan Zamazal,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/49674

to review the following change.

Change subject: vm: add support for "Crashed" event
......................................................................

vm: add support for "Crashed" event

Libvirt recently added this event.
We seen this first on libvirt 1.2.17 on ppc64le.

Change-Id: I96e98cf7dc9c2c9e7507cc39e181fb2953032989
Related-To: https://bugzilla.redhat.com/1273891
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1284564
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48594
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48790
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/49674/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 8bc545a..c809e63 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -183,7 +183,7 @@
 
 
 # These strings are representing libvirt virDomainEventType values
-# http://libvirt.org/html/libvirt-libvirt.html#virDomainEventType
+# http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainEventType
 _EVENT_STRINGS = (
     "Defined",
     "Undefined",
@@ -193,6 +193,7 @@
     "Stopped",
     "Shutdown",
     "PM-Suspended",
+    "Crashed",
 )
 
 


-- 
To view, visit https://gerrit.ovirt.org/49674
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96e98cf7dc9c2c9e7507cc39e181fb2953032989
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>


More information about the vdsm-patches mailing list