Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

vfeenstr at redhat.com vfeenstr at redhat.com
Thu Dec 3 14:52:06 UTC 2015


Vinzenz Feenstra has posted comments on this change.

Change subject: guest-agent: desktopLock exception on EBADF should be ignored
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/47404/5//COMMIT_MSG
Commit Message:

Line 7: guest-agent: desktopLock exception on EBADF should be ignored
Line 8: 
Line 9: There's no more logging of the EBADF exceptions on desktopLock, since
Line 10: this is very likely to happen on a migration and in general does not
Line 11: provide with any additional value.
> Should add also that EBADF means the socket was closed.
This is quite simple to explain - desktopLock is triggered 4 times due to 4 display disconnect events received from the lifecycle events, we have introduced already some improvement here.

There is a forced timeout of 2 seconds before calling desktopLock to avoid locking the screen when migrating. These are, for at least me, all known implications.

The only thing that shouldn't be logged here is the EBADF on the disconnect event.

This is all less problematic than you might see it.
Line 12: 
Line 13: All other exceptions are still logged, in case something unexpected
Line 14: happens.
Line 15: 


-- 
To view, visit https://gerrit.ovirt.org/47404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd032471396a97999c2cea5c88ae04ec8ca4028
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list